Fix UI bugs #96

LuLuKitty1998 · 2024-07-29T17:08:28Z

Fix UI Bugs and Improve GUI

Description/Motivation/Screenshots

This patch addresses several UI bugs and crashes in the CEmu GUI, making it more stable and user-friendly. The changes include:

Fixing multiple crashes related to the GUI.
Enhancing the overall stability of the application.
Resolving bugs specific to the Windows platform.

These changes are required to improve the user experience by providing a more stable and reliable interface. The fixes ensure that users encounter fewer crashes and bugs, especially on Windows. By enhancing the stability and usability of CEmu, this patch contributes to a smoother and more enjoyable experience for users, encouraging more people to use and contribute to the project. Screenshots showcasing the improved GUI have been added to the README.md file for reference.

Checklist

[ ] My PR was done against the main branch, not dev.
[x] My code follows the code style of this project.
[ ] My change includes a change to the documentation, if required.

- Emptied default.qss to allow system dark and light modes to apply properly. - Ensures compatibility with Cleanlooks theme in PyQt6.

- Added .idea/ to .gitignore to prevent JetBrains IDE configuration files from being tracked. - Helps keep the repository clean and focused on source code.

- Corrected typos in the configuration file. - Updated default width and height values for better display of the window.

…_.py - Added exception handling to manage cases where syscall files do not exist for specific architectures (e.g., Generic). - Display a PyQt6 QMessageBox with the exception message to inform the user.

- Added is_dark_mode function to check if the current palette is in dark mode. - Uses QPalette to determine if the window color value is less than 128.

- Changed column width from 60 to 80 in RegisterWidget class. - Improves the display of register names and values in the table.

- Increased column widths to 120 for better display in MemoryMappingWidget. - Set fixed width of MemoryMapTableWidget to 350. - Corrected typo in permission checkbox label from 'eXecute' to 'Execute'.

- Enhanced CommandWidget to show tooltips when hovering over QPushButtons. - Tooltips provide additional context for each button's functionality.

- Wrapped self.setup() method in try-except to handle exceptions gracefully. - Added QMessageBox to display error messages when setup fails. - Removed unnecessary reassignment of self.codelines in reset method to prevent crashes. - Modified next_instruction method to return Optional, returning None when no instructions remain instead of raising an exception.

- Increased fixed width of AssemblyView from 140 to 230 for better display. - Removed background color stylesheet for better harmony in dark mode. - Fixed bug in update_assembly_code_pane method to correctly handle line returns on Windows by using '\n' instead of os.linesep.

…highlighter.py - Organized imports for better readability and maintenance. - Removed unneeded return statements at the end of None type methods.

…arious bugs in cemu/ui/main.py - Enhanced dock widget positions for better user experience in CEmuWindow class. - Implemented StartInFullScreen with global settings stored in ini file. - Changed default window width and height to 800x600 instead of 1600x800. - Fixed bug in Architecture menu for proper switching between x86 AT&T and Intel syntax in different bits (16, 32, 64). - Fixed bug in showShortcutPopup method with incorrect string format syntax. - Fixed crash in EmulationRunner class method run when no instructions remain.

- Add various functions for ui dark mode in cemu/ui/utils.py - Improve syntax highlighting for ui dark mode in cemu/ui/highlighter.py

- Added new screenshots for GUI

hugsy · 2024-07-29T19:56:05Z

Looks epic, thanks @LuLuKitty1998 !
It looks ok at a first glance, but give me a bit of time to review in more depth

hugsy

A few minor things to change but really looks good
I tried to provide suggestions to make the changes easier.

hugsy · 2024-07-29T19:59:36Z

cemu/arch/__init__.py

+                msgbox = QMessageBox()
+                msgbox.setIcon(QMessageBox.Icon.Critical)
+                msgbox.setWindowTitle("No Syscall File Error")
+                msgbox.setText(str(e))
+                msgbox.exec()


You can use cemu.ui.popup to make this a bit smaller

hugsy · 2024-07-29T19:59:56Z

cemu/arch/__init__.py

+                msgbox.setWindowTitle("No Syscall File Error")
+                msgbox.setText(str(e))
+                msgbox.exec()
+                pass


Suggested change

pass

return {}

hugsy · 2024-07-29T20:02:43Z

cemu/emulator.py

+                    msgbox = QMessageBox()
+                    msgbox.setIcon(QMessageBox.Icon.Critical)
+                    msgbox.setWindowTitle("Emulator setup error")
+                    msgbox.setText(str(e))
+                    msgbox.exec()


Can use popup here too

hugsy · 2024-07-29T20:04:37Z

cemu/ui/codeeditor.py

@@ -16,12 +16,11 @@
 )

 import cemu.core
+from build.lib.cemu.const import DEFAULT_CODE_VIEW_FONT, DEFAULT_CODE_VIEW_FONT_SIZE


what's build.lib here?

I think PyCharm IDE optimized imports by mistake :) instead of import from cemu.const imported from different directory

hugsy · 2024-07-29T20:06:04Z

cemu/ui/codeeditor.py

@@ -34,30 +33,22 @@


 class CodeEdit(QTextEdit):
-    def __init__(self, parent):
+    def __init__(self, parent=None):


Can you add type hints too?

Suggested change

def __init__(self, parent=None):

def __init__(self, parent: Optional[QtWidget] = None):

hugsy · 2024-07-29T20:27:00Z

cemu/ui/utils.py

+    return palette.color(QPalette.ColorRole.Window).value() < 128
+
+
+def brighten_color(hex_color: str, percent: float):


Suggested change

def brighten_color(hex_color: str, percent: float):

def brighten_color(hex_color: str, percent: float) -> str:

hugsy · 2024-07-29T20:27:51Z

cemu/ui/utils.py

+    return f'{r:02x}{g:02x}{b:02x}'
+
+
+def hex_to_rgb(hex_color: str):


Suggested change

def hex_to_rgb(hex_color: str):

def hex_to_rgb(hex_color: str) -> tuple[int, int, int]:

hugsy · 2024-07-29T20:28:02Z

cemu/ui/utils.py

+    return tuple(int(hex_color[i:i + 2], 16) for i in (0, 2, 4))
+
+
+def is_red(hex_color: str):


Suggested change

def is_red(hex_color: str):

def is_red(hex_color: str) -> bool:

hugsy · 2024-07-29T20:29:15Z

cemu/ui/utils.py

+    return r > g and r > b
+
+
+def is_green(hex_color: str):


Suggested change

def is_green(hex_color: str):

def is_green(hex_color: str) -> bool:

hugsy · 2024-07-29T20:29:26Z

cemu/ui/utils.py

+    return g > r and g > b
+
+
+def is_blue(hex_color: str):


Suggested change

def is_blue(hex_color: str):

def is_blue(hex_color: str) -> bool:

hugsy · 2024-07-29T21:19:18Z

FWIW the packaging system has changed making CI fail. You can ignore the CI failures

hugsy · 2024-07-30T15:52:48Z

Awesome PR, merged!
Thanks!

LuLuKitty1998 added 14 commits July 29, 2024 01:34

Update default.qss to better support for Cleanlooks theme in PyQt6

2fe028e

- Emptied default.qss to allow system dark and light modes to apply properly. - Ensures compatibility with Cleanlooks theme in PyQt6.

Update .gitignore to exclude .idea directory

58d659a

- Added .idea/ to .gitignore to prevent JetBrains IDE configuration files from being tracked. - Helps keep the repository clean and focused on source code.

Fix typos and update default window dimensions in cemu.ini

95f2b76

- Corrected typos in the configuration file. - Updated default width and height values for better display of the window.

Add exception handling for missing syscall files in cemu/arch/__init_…

68697e7

…_.py - Added exception handling to manage cases where syscall files do not exist for specific architectures (e.g., Generic). - Display a PyQt6 QMessageBox with the exception message to inform the user.

Add function to determine dark mode in cemu/ui/utils.py

3480e7f

- Added is_dark_mode function to check if the current palette is in dark mode. - Uses QPalette to determine if the window color value is less than 128.

Enhance RegisterWidget in cemu/ui/registers.py

28e3c17

- Changed column width from 60 to 80 in RegisterWidget class. - Improves the display of register names and values in the table.

Enhance MemoryMappingWidget and fix typos in cemu/ui/mapping.py

6bfa751

- Increased column widths to 120 for better display in MemoryMappingWidget. - Set fixed width of MemoryMapTableWidget to 350. - Corrected typo in permission checkbox label from 'eXecute' to 'Execute'.

Add tooltips to CommandWidget buttons in cemu/ui/command.py

e9e9fe1

- Enhanced CommandWidget to show tooltips when hovering over QPushButtons. - Tooltips provide additional context for each button's functionality.

Organize imports and remove unnecessary return statements in cemu/ui/…

444dd0e

…highlighter.py - Organized imports for better readability and maintenance. - Removed unneeded return statements at the end of None type methods.

Enhance code highlighting in dark mode

06f747d

- Add various functions for ui dark mode in cemu/ui/utils.py - Improve syntax highlighting for ui dark mode in cemu/ui/highlighter.py

Update README.md

ddd9264

- Added new screenshots for GUI

hugsy self-requested a review July 29, 2024 19:56

hugsy added enhancement ui labels Jul 29, 2024

hugsy added this to the 0.8 milestone Jul 29, 2024

hugsy requested changes Jul 29, 2024

View reviewed changes

hugsy mentioned this pull request Jul 29, 2024

Text is white on windows. #95

Closed

3 tasks

Add type hints and some minor changes to improve code readability

8281b1d

LuLuKitty1998 requested a review from hugsy July 30, 2024 00:00

hugsy approved these changes Jul 30, 2024

View reviewed changes

hugsy merged commit 4cad30a into hugsy:main Jul 30, 2024

LuLuKitty1998 deleted the fix-ui-bugs branch July 30, 2024 19:02

	def __init__(self, parent=None):
	def __init__(self, parent: Optional[QtWidget] = None):

		return palette.color(QPalette.ColorRole.Window).value() < 128


		def brighten_color(hex_color: str, percent: float):

		return f'{r:02x}{g:02x}{b:02x}'


		def hex_to_rgb(hex_color: str):

	def hex_to_rgb(hex_color: str):
	def hex_to_rgb(hex_color: str) -> tuple[int, int, int]:

		return tuple(int(hex_color[i:i + 2], 16) for i in (0, 2, 4))


		def is_red(hex_color: str):

	def is_red(hex_color: str):
	def is_red(hex_color: str) -> bool:

	def is_green(hex_color: str):
	def is_green(hex_color: str) -> bool:

	def is_blue(hex_color: str):
	def is_blue(hex_color: str) -> bool:

Uh oh!

Fix UI bugs #96

Fix UI bugs #96

Uh oh!

Conversation

LuLuKitty1998 commented Jul 29, 2024

Fix UI Bugs and Improve GUI

Description/Motivation/Screenshots

Uh oh!

hugsy commented Jul 29, 2024

Uh oh!

hugsy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hugsy commented Jul 29, 2024

Uh oh!

hugsy commented Jul 30, 2024

Uh oh!

Uh oh!