Skip to content

Do not test for iOS #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hugovk merged 4 commits into from
Nov 28, 2023
Merged

Do not test for iOS #107

hugovk merged 4 commits into from
Nov 28, 2023

Conversation

@radarhere
Copy link

@radarhere radarhere commented Nov 28, 2023

Suggestions for python-pillow#7579

  • Do not test for iOS. We don't have an iOS tab
  • Update a comment now that we're no longer searching for text "containing" the OS
  • window.navigator?.userAgentData is used, after window.navigator.userAgent is used. So there's no point having the second window.navigatior be optional
  • You've introduced html_js_files, so I've moved the existing CSS file into html_css_files

@hugovk hugovk merged commit 6d90f98 into hugovk:docs-activate-tab Nov 28, 2023
@hugovk
Copy link
Owner

hugovk commented Nov 28, 2023

Thanks!

@radarhere radarhere deleted the docs-activate-tab branch November 28, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@radarhere @hugovk