Throw relevant error when inference fails #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clefourrier
reviewed
Apr 10, 2025
| logger.warning("Empty response or missing .choices from model {}", model.model_name) | ||
| return "" | ||
| logger.error("Empty response or missing .choices from model {}", model.model_name) | ||
| raise Exception("Failed Inference") |
There was a problem hiding this comment.
Where is this error caught for a retry?
There was a problem hiding this comment.
It's actually caught in the outer function from where it's called
There was a problem hiding this comment.
clefourrier
approved these changes
Apr 10, 2025
Josephrp
pushed a commit
to Josephrp/yourbench
that referenced
this pull request
Jun 5, 2025
Throw relevant error when inference fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's a failed inference (without
.choices, an error must be raised so that it can be retried).Also change the timeout, so it's 5 minutes, instead of 1 hour.