Make "fast_chunking" the default chunking mode and preserve semantic mode under config #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clefourrier
approved these changes
Mar 31, 2025
|
And ofc, fix the style first |
|
fixed style! |
|
multi-hop wouldn't be affected - as all multi-hop chunks are just combos of single hop chunks! |
Josephrp
pushed a commit
to Josephrp/yourbench
that referenced
this pull request
Jun 5, 2025
Make "fast_chunking" the default chunking mode and preserve semantic mode under config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
fast_chunking: Introduced a new “fast_chunking” logic that creates chunks purely based on maximum token length. This mode avoids embedding computation and similarity checks."chunking_mode": "semantic_chunking".chunking_modeField: The new field inChunkingParametersdecides which approach to use, defaulting to"fast_chunking"if not explicitly configured.Tested to work