fix: define TransformersCompletionCreateParamsStreaming inside conditional to avoid NameError when serve is unavailable (closes #46657)#46671
Closed
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
…ional to avoid NameError when serve is unavailable (closes huggingface#46657)
Contributor
|
CI Dashboard: View test results in Grafana |
Member
|
This is unrelated to the linked issue. Your bot is broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When
is_serve_available()returns False (e.g., missing OpenAI package), the classCompletionCreateParamsStreamingis never imported, causing aNameErrorat the definition ofTransformersCompletionCreateParamsStreaming.Fix
Move the definition of
TransformersCompletionCreateParamsStreaminginside the same conditional block whereCompletionCreateParamsStreamingis imported, so it is only defined when the required dependency is available.Closes #46657