Skip to content

Fix peft lower bound#46605

Merged
vasqu merged 1 commit into
huggingface:mainfrom
hmellor:fix-peft-bound
Jun 12, 2026
Merged

Fix peft lower bound#46605
vasqu merged 1 commit into
huggingface:mainfrom
hmellor:fix-peft-bound

Conversation

@hmellor

@hmellor hmellor commented Jun 12, 2026

Copy link
Copy Markdown
Member

As of #45155, Transformers started importing from peft.utils.save_and_load import _maybe_shard_state_dict_for_tp in the peft integration. This import did not exist until huggingface/peft#3096, which was first released in peft==0.19.0.

This PR corrects the peft lower bound.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@SunMarc SunMarc enabled auto-merge June 12, 2026 15:24
@SunMarc SunMarc self-requested a review June 12, 2026 15:24

@SunMarc SunMarc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM !

@hmellor hmellor disabled auto-merge June 12, 2026 15:25
@hmellor hmellor enabled auto-merge June 12, 2026 15:27
@github-actions

Copy link
Copy Markdown
Contributor

CI Dashboard: View test results in Grafana

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions

Copy link
Copy Markdown
Contributor

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=46605&sha=a04868

@SunMarc SunMarc disabled auto-merge June 12, 2026 16:15
@SunMarc SunMarc requested a review from vasqu June 12, 2026 16:19
@SunMarc

SunMarc commented Jun 12, 2026

Copy link
Copy Markdown
Member

Can you merge the PR @vasqu ?

@vasqu

vasqu commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Lemme retry running the CI job but will merge afterwards

@vasqu vasqu added this pull request to the merge queue Jun 12, 2026
Merged via the queue into huggingface:main with commit d3fabcf Jun 12, 2026
120 checks passed
@hmellor hmellor deleted the fix-peft-bound branch June 12, 2026 17:25
hmellor added a commit that referenced this pull request Jun 12, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
vasqu pushed a commit that referenced this pull request Jun 15, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants