a11 for checkers#46599
Merged
Merged
Conversation
Contributor
|
CI Dashboard: View test results in Grafana |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
reviewed
Jun 12, 2026
Comment on lines
+76
to
+95
| class _NullTrace: | ||
| """No-op with the same shape as transformersci.otel.instrument's Run/Step.""" | ||
|
|
||
| def run(self, *args, **kwargs): | ||
| return self | ||
|
|
||
| def step(self, *args, **kwargs): | ||
| return self | ||
|
|
||
| def __enter__(self): | ||
| return self | ||
|
|
||
| def __exit__(self, *exc): | ||
| return False | ||
|
|
||
| def set_exit_code(self, returncode): | ||
| pass | ||
|
|
||
|
|
||
| _tracer = _otel if _otel is not None else _NullTrace() |
Collaborator
There was a problem hiding this comment.
For the usual pytest one, do we need or already use similar _NullTrace?
Collaborator
Author
There was a problem hiding this comment.
for pytest it's internal to the pytest-opentelemetry plugin so it's not surfaced in our tests at all
ydshieh
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds OTEL traces for checkers