[DiffusionGemma] Add DDIM and block refinement samplers#46595
Open
kashif wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
cc @gante and @sayakpaul |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
gante
reviewed
Jun 12, 2026
Contributor
Author
|
running benchmarks as i type |
Contributor
|
It would be cool to measure both quality and tokens per forward! (I added tokens per forward as part of the output class in |
Contributor
|
P.S.: In the first few commits I considered writing a base class for all samplers, since they will almost certainly share the random canvas initialization 🤗 |
72ada7e to
af52a19
Compare
Contributor
|
CI Dashboard: View test results in Grafana |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: diffusion_gemma |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two more samplers for DiffusionGemma so people can try different denoising strategies without writing their own.
DiscreteDDIMSampler: samples each canvas position from the exact posterior of the uniform corruption process. Works well with a constant temperature and around 20 steps.BlockRefinementSampler: commits an even share of the canvas per step, most confident tokens first, with optional editing of committed tokens.The sampler is picked through
sampler_config, same as the existingEntropyBoundSampler. Added unit tests for both, parametrized the generate test over them, and documented them in the model page.Tests:
pytest tests/models/diffusion_gemma/test_generation_diffusion_gemma.pyandtest_modeling_diffusion_gemma.py -k test_generatepass on CPU.AI assistance was used.