[CB] Fix seqlens and use TypedDict#46593
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Jun 12, 2026
Contributor
|
CI Dashboard: View test results in Grafana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a race condition where the
cumulative_seqlenstensors would be padded on the device during their transfer. It seems the bug did not happen often in a non-distributed setting, but it appeared when running the continuous batching overall script in DP 8. It is now fixed: the padding happens before the tensor is constructed and moved to the device.This PR also removes the
@dataclassdecorator that was used to definePagedAttentionArgsin favor of aTypedDict, which is cleaner.Performance ✅
No performance changes
Tests ✅
All tests pass.
AI Review ✅
Reviewed by claude