Fix InternVL models#46524
Merged
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
6 tasks
itazap
approved these changes
Jun 9, 2026
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hmellor
added
the
for patch
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto |
Contributor
|
CI Dashboard: View test results in Grafana |
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=46524&sha=d8569a |
louzongzhi
pushed a commit
to louzongzhi/transformers
that referenced
this pull request
Jun 10, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
louzongzhi
pushed a commit
to louzongzhi/transformers
that referenced
this pull request
Jun 10, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
ArthurZucker
pushed a commit
that referenced
this pull request
Jun 11, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #45078 (first released in v5.6.0), the fallback from
TokenizersBackendtotokenizer_config.tokenizer_classhas been removed.internvl_chathad been added toMODELS_WITH_INCORRECT_HUB_TOKENIZER_CLASSso that it would explicitly useTokenizersBackendinstead of the class specified in itstokenizer_config. However, it appears thatinternvl_chatwas actually using this fallback and therefore was actually loading the class specified bytokenizer_config.This PR removes
internvl_chatfromMODELS_WITH_INCORRECT_HUB_TOKENIZER_CLASSso that the model can be loaded again with the same behaviour as in <v5.6.0.