Skip to content

[CB] [Minor] Add data-parallel to overall script#46490

Merged
remi-or merged 8 commits into
mainfrom
cb-distributed-overall
Jun 11, 2026
Merged

[CB] [Minor] Add data-parallel to overall script#46490
remi-or merged 8 commits into
mainfrom
cb-distributed-overall

Conversation

@remi-or

@remi-or remi-or commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

This PR adds a data-parallel mode to the continuous_batching_overall.py script that we use to benchmark the performance of CB across a range of use cases.
Until now, the script did not allow to leverage all the GPUs on a node because it only supported TP: if a user wanted to run 16 benchmarks on a 8 GPUs node with the model on a single GPU, the 16 benchmarks ran on the same GPU, in order. Now each GPU will get 16 / 2 = 8 benchmarks if --dp-size 8 is passed (must be run with torchrun). This drastically decreases the time needed to run the full benchmark suite ofc.

@remi-or remi-or requested a review from ArthurZucker June 8, 2026 06:17
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@remi-or remi-or force-pushed the cb-distributed-overall branch from 83c6c34 to b34710a Compare June 10, 2026 05:03
@remi-or remi-or changed the title [CB] Add data-parallel to overall script [CB] [Minor] Add data-parallel to overall script Jun 10, 2026
@remi-or remi-or enabled auto-merge June 10, 2026 06:39
@remi-or remi-or self-assigned this Jun 10, 2026
@remi-or remi-or disabled auto-merge June 10, 2026 07:39
@remi-or remi-or enabled auto-merge June 10, 2026 07:42
@github-actions

Copy link
Copy Markdown
Contributor

CI Dashboard: View test results in Grafana

@remi-or remi-or added this pull request to the merge queue Jun 11, 2026
Merged via the queue into main with commit acc2cda Jun 11, 2026
119 of 120 checks passed
@remi-or remi-or deleted the cb-distributed-overall branch June 11, 2026 03:00
@github-project-automation github-project-automation Bot moved this from In review to Done in Continuous batching Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants