Skip to content

Llama3 video fix#45040

Merged
zucchini-nlp merged 6 commits into
huggingface:mainfrom
sywangyi:llama3_video_fix
Apr 29, 2026
Merged

Llama3 video fix#45040
zucchini-nlp merged 6 commits into
huggingface:mainfrom
sywangyi:llama3_video_fix

Conversation

@sywangyi

Copy link
Copy Markdown
Contributor

when running tests/models/video_llama_3/test_modeling_video_llama_3.py::VideoLlama3IntegrationTest all fail cause by lm_head.weight is missing.

Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
@ydshieh

ydshieh commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

@zucchini-nlp

The current failure (on main) is from

Untangle config inheritance (#41541)

For this PR, it fixed the CI, but I don't know if it's the best / correct way.

Could you check, taking the above context.

Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
@sywangyi

Copy link
Copy Markdown
Contributor Author

this issue still exists in the latest main, will you consider merging the PR @ydshieh @zucchini-nlp ?

@zucchini-nlp zucchini-nlp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, notifications in gh get lost sometimes 🫠

I'll trigger a slow CI and will merge

@zucchini-nlp

Copy link
Copy Markdown
Member

run-slow: video_llama_3

@github-actions

Copy link
Copy Markdown
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/video_llama_3"]
quantizations: []

@github-actions

Copy link
Copy Markdown
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN fb0e325e workflow commit (merge commit)
PR 8d065d33 branch commit (from PR)
main 9120f5e4 base commit (on main)

Model CI Report

2 new failed tests from this PR 😭

  • video_llama_3:
    tests/models/video_llama_3/test_modeling_video_llama_3.py::VideoLlama3IntegrationTest::test_small_model_integration_test_batch_different_resolutions (❌ ⟹ ❌)
    tests/models/video_llama_3/test_modeling_video_llama_3.py::VideoLlama3IntegrationTest::test_small_model_integration_test_batch_wo_image (❌ ⟹ ❌)

@zucchini-nlp

Copy link
Copy Markdown
Member

I will fix it on your behalf by checking inside CI runners, looks like a diff due to hardware

@github-actions

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: video_llama_3

@zucchini-nlp

Copy link
Copy Markdown
Member

run-slow: video_llama_3

@github-actions

Copy link
Copy Markdown
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/video_llama_3"]
quantizations: []

@github-actions

Copy link
Copy Markdown
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 8378b609 workflow commit (merge commit)
PR 7f19a358 branch commit (from PR)
main 223fe523 base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@zucchini-nlp zucchini-nlp added this pull request to the merge queue Apr 29, 2026
Merged via the queue into huggingface:main with commit d1969ba Apr 29, 2026
22 checks passed
@sywangyi sywangyi deleted the llama3_video_fix branch May 20, 2026 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants