Skip to content

add pytorch-xpu Dockerfile #38875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 20, 2025
Merged

add pytorch-xpu Dockerfile #38875

merged 5 commits into from
Jun 20, 2025

Conversation

yao-matrix
Copy link
Contributor

No description provided.

Signed-off-by: YAO Matrix <[email protected]>
@yao-matrix yao-matrix marked this pull request as draft June 18, 2025 02:31
Signed-off-by: YAO Matrix <[email protected]>
@ydshieh
Copy link
Collaborator

ydshieh commented Jun 18, 2025

I am open to this. But do you think it's better to have this within transformers repository and build the images in our GitHub Actions?

I think it also works very well if this is in one of Intel XPU repository and build the image there ..?

@yao-matrix
Copy link
Contributor Author

I think finally we'll integrate XPU into transformers in-tree CI pipeline, the prior work has enabled XPU w/ a good pass rate, integrating XPU into in-tree CI will enable us spot and fix issues in day-0.

@ydshieh
Copy link
Collaborator

ydshieh commented Jun 19, 2025

Do you mean the CI for XPU will be triggered from huggingface/transformres GitHub Actions .. ?
(Do we, huggingface, have the access to XPU runners, via Github Actions)?

OK, ping me once this PR is ready.

@yao-matrix
Copy link
Contributor Author

Do you mean the CI for XPU will be triggered from huggingface/transformres GitHub Actions .. ? (Do we, huggingface, have the access to XPU runners, via Github Actions)?

OK, ping me once this PR is ready.

We've shared some XPU devices(1 or 2) w/ HF through Intel Cloud, I suppose they are mainly on TGI and BNB now. And I suppose there are some work planned to make XPU available in HF datacenter. I suppose we'll finally let CI for XPU triggered from transformers github actions. That's why we are preparing PRs to make sure we prepare well from engineering side, :).

@yao-matrix yao-matrix marked this pull request as ready for review June 19, 2025 23:29
@github-actions github-actions bot requested review from ArthurZucker and ydshieh June 19, 2025 23:30
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thank you, I will leave you to maintain this :-) 🙏

I assume you tested this docker file could be built. Do we want to add the build to

.github/workflows/build-docker-images.yml

?

@ydshieh ydshieh merged commit 38a9b70 into huggingface:main Jun 20, 2025
9 checks passed
@yao-matrix
Copy link
Contributor Author

OK, thank you, I will leave you to maintain this :-) 🙏

I assume you tested this docker file could be built. Do we want to add the build to

.github/workflows/build-docker-images.yml

?

Yes, this is the Dockerfile we are using daily and originally kept in our internal repo, it works. And i will maintain it and upgrade it to make it up-to-date.

for adding it to ".github/workflows/build-docker-images.yml", sure, let me do it.

@yao-matrix yao-matrix deleted the docker-xpu branch June 23, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants