Support the complex64 data type #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldk
force-pushed
the
add-complex64
branch
from
308ada5 to
e262d9f
Compare
McPatate
reviewed
Oct 17, 2025
safetensors/src/tensor.rs
Outdated
Comment on lines
809
to
810
| /// Complex (32-bit parts) | ||
| Complex64, |
Member
Author
There was a problem hiding this comment.
Yeah:
>>> x = torch.zeros(1, dtype=torch.complex64)
>>> x.real.dtype
torch.float32
>>> x.imag.dtype
torch.float32
Member
There was a problem hiding this comment.
somehow didn't parse parts (with an s), which was pretty clear, mb 🙃
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Narsil
reviewed
Oct 26, 2025
safetensors/src/tensor.rs
Outdated
| Dtype::BF16 => "BF16", | ||
| Dtype::F32 => "F32", | ||
| Dtype::F64 => "F64", | ||
| Dtype::Complex64 => "Complex64", |
Contributor
There was a problem hiding this comment.
Any way we could keep things in line with what's before "C64" just for consistency's sake ?
Hi guys !
Member
Author
There was a problem hiding this comment.
Hey hey! Hope you are doing great!
Changed to C64, now one can only hope for a type A500 in the future 😁.
Member
There was a problem hiding this comment.
Feels a bit confusing to have it be C64 in one place but Complex64 everywhere else imo
danieldk
force-pushed
the
add-complex64
branch
from
992c4ad to
5c07663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: not ready for review yet, I just want a CI run :).
What does this PR do?
Fixes # (issue) or description of the problem this PR solves.