Skip to content

Pass device to torch.asarray in get_tensor #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Narsil merged 2 commits into from
Mar 17, 2025
Merged

Pass device to torch.asarray in get_tensor #588

Narsil merged 2 commits into from
Mar 17, 2025

Conversation

@mickvangelderen
Copy link
Contributor

@mickvangelderen mickvangelderen commented Mar 14, 2025 •
edited
Loading

What does this PR do?

Fixes #582

This was referenced Mar 14, 2025
Closed
Closed
@Narsil Narsil marked this pull request as ready for review March 17, 2025 09:13
Narsil
Narsil approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Narsil Narsil merged commit 62155a5 into huggingface:main Mar 17, 2025
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Narsil Narsil Narsil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

load_file does apply to(device) when device = "cpu"

2 participants

@mickvangelderen @Narsil