Skip to content

support no_std #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Narsil merged 2 commits into from
Jan 7, 2025
Merged

support no_std #556

Narsil merged 2 commits into from
Jan 7, 2025

Conversation

@ivila
Copy link
Contributor

@ivila ivila commented Jan 3, 2025

What does this PR do?

Fixes #544
Core changes are:

  1. add features: [default, std, alloc]: developers must choose either std or alloc, default to std
  2. if no std: use hashbrown::HashMap as alternative to std::collections::HashMap
  3. if no std: remove IoError from Error enum, and remove serialize_to_file

Narsil
Narsil approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for this, pretty clean implementation !

@Narsil Narsil merged commit 38a3629 into huggingface:main Jan 7, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Narsil Narsil Narsil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support no_std

2 participants

@ivila @Narsil