Skip to content

set default temperature to 0 in generation config #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NathanHB
Copy link
Member

No description provided.

@NathanHB NathanHB requested a review from Copilot June 17, 2025 13:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GenerationParameters model to default temperature to 0 (greedy decoding) instead of None.

  • Changed temperature from NonNegativeFloat | None = None to NonNegativeFloat = 0
  • Removed support for None as a temperature value
  • Added inline comment clarifying default greedy decoding behavior
Comments suppressed due to low confidence (3)

src/lighteval/models/model_input.py:39

  • Changing the default for temperature from None to 0 is a breaking API change; consider documenting this in the CHANGELOG and bumping the version or adding a deprecation note for the old behavior.
    temperature: NonNegativeFloat = (

src/lighteval/models/model_input.py:39

  • Add or update unit tests to cover the new default temperature=0 behavior and verify that greedy decoding is triggered when no custom value is provided.
    temperature: NonNegativeFloat = (

src/lighteval/models/model_input.py:40

  • Update the class docstring or external documentation to reflect that temperature now defaults to 0 and that passing None is no longer supported.
        0  # vllm, transformers, tgi, litellm, sglang # if not set, defaults to greedy decoding

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants