HDF5 support #7690
Open
HDF5 support #7690
+1,221
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A few to-dos which I think can be left for future PRs (which I am happy to do/help with -- just this one is already huge 😄 ):
|
klamike
commented
Jul 23, 2025
klamike
commented
Jul 23, 2025
|
@lhoestq any interest in merging this? Let me know if I can do anything to make reviewing it easier! |
|
Sorry for the delay, I'll review your PR soon :) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
lhoestq
reviewed
Aug 11, 2025
|
Thanks for the review @lhoestq! Rebased on main and incorporated most of your suggestions. I believe the only one left is the zero-dim handling with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for tabular HDF5 file(s) by converting each row to an Arrow table. It supports columns with the usual dtypes including up to 5-dimensional arrays as well as support for complex/compound types by using
Features(dict). All datasets within the HDF5 file should have rows on the first dimension (groups/subgroups are still allowed). Closes #3113.Replaces #7625 which only supports a relatively small subset of HDF5.