Fix cn_metrics.py not to fail on empty yaml input #342
Conversation
Signed-off-by: Greg Becker <[email protected]>
|
This hack should get SQA back on track, maybe some Python experts can help me out :-) |
| try: | ||
| from typing import OrderedDict | ||
| except ImportError: | ||
| from typing import Dict as OrderedDict |
There was a problem hiding this comment.
Does the dict have to be ordered?
There was a problem hiding this comment.
Only to preserve column order...
tools/scripts/cn_metrics.py
Outdated
| # TODO: How to test if ybuf[] contain at least one "nodes" stanza? | ||
| # | ||
| try: | ||
| for node in ybuf["nodes"]: |
There was a problem hiding this comment.
Wait, that only works if "nodes" is in ybuf...
There was a problem hiding this comment.
ybuf is some kind of monstrosity i don't grok, it returns NoneType if "nodes" is not in ybuf, but you shouldn't test explicitly for None/NoneType, not to mention the none stuff seems to vary depending on Python version, uhg...
There was a problem hiding this comment.
"nodes" in ybuf
tells you that there is a key called "nodes". If you are looking to make sure there is a node in the array, then do this:
if ybuf.get("nodes", []): return
There was a problem hiding this comment.
That doesn't work, it always returns true.
Cuz.. I'm an idiot, thanks Tristan!
Signed-off-by: Greg Becker <[email protected]>
Signed-off-by: Greg Becker [email protected]