Custom Linting Tests and Refactoring of Testing Package #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lasklu
approved these changes
Jun 13, 2020
Mrnikbobjeff
pushed a commit
that referenced
this pull request
Jun 18, 2020
* removed trunk (#130) * removed trunk also in main.yml (#134) * removed trunk * also changed main.yml * Fixed .sqout and package structure (#120) * fix for linter * replaced ui package Co-authored-by: Jonas Schmidt <[email protected]> * Fixed installation Instructions * fixed linux installation instructions * added FFI installation instruction * detailled instruction 2, removed instruction 5 * Update Windows installation instructions * Fixed image link * Removed duplicate text Co-authored-by: sspangenberg <[email protected]> Co-authored-by: Niklas Schilli <[email protected]> * Refactored chatsList and added Back Button at Auth (#135) * added tccchats * added tccrequest * fixed tdparams * fixes * Fixed UI problems * Now properly sorting chatsList * Started refactoring loading of Chats. This is only a Backup commit if squeak crashes! * Now cleanly handling loading of Chats with ChatsHandler. But order not working yet * removed accidental halt * addChat is now part of ChatsHandler * Added BackButton, in case that User enters wrong phone number and want to go a step back * Merged Dev into this branch Co-authored-by: Jonas Schmidt <[email protected]> * Revert "Refactored chatsList and added Back Button at Auth (#135)" (#136) This reverts commit 43fc1d2. * Refactored chatsList to follow tdLib standards (#137) * small fixes * removed debugging code * added tccchats * added tccrequest * fixed tdparams * fixes * Fixed UI problems * Now properly sorting chatsList * Started refactoring loading of Chats. This is only a Backup commit if squeak crashes! * Now cleanly handling loading of Chats with ChatsHandler. But order not working yet * removed accidental halt * addChat is now part of ChatsHandler * Added BackButton, in case that User enters wrong phone number and want to go a step back Co-authored-by: Jonas Schmidt <[email protected]> Co-authored-by: Jonas Schmidt <[email protected]> Co-authored-by: Jonas Schmidt <[email protected]> * Sending of Messages added (#138) * added tccchats * added tccrequest * fixed tdparams * fixes * Fixed UI problems * Now properly sorting chatsList * Started refactoring loading of Chats. This is only a Backup commit if squeak crashes! * Now cleanly handling loading of Chats with ChatsHandler. But order not working yet * removed accidental halt * addChat is now part of ChatsHandler * added send message methods in core without ui wip * merge * random merge * merge fix * Fixed identation * Satisfiying linterTests - categorized all uncategorized * Removed Legacy Stuff Co-authored-by: Jonas Schmidt <[email protected]> Co-authored-by: Frederik Wollny <[email protected]> Co-authored-by: Jonas Schmidt <[email protected]> * Support sending Messages via UI (#139) * Can now selected and deselct chats - hiding and showing inputField for sending Message to this chat * Added Welcome Message and Listeners * Send Button and TextInput added, needs to be connected to Core now * Connected UI to chat sending * Linter Tests satisfied now :) * classified class-side methods * Custom Linting Tests and Refactoring of Testing Package (#140) * started editing linting rules * refactoring linter tests * some linter fixes * formatting linter * no more testing for ffi methods * wip linting * custom linter tests yay * better custom linter tests * more linter tests * class comments and scoped environment for faster testing * some fixes * linter fixes * refactoring * refactored to make all linter tests happy * final linting changes * removed two tests * Added Support for Telegram TestDatabase Service (#142) * added TCUApp newWithTCCTestApp for automatic test db login * Refactored so that TestApp and TestAuthHandler inherits from parent. They are now located in TCT Package * Added LoginWithTestData method for TCCApp to use our registered TestData and directly be logged In * Satisfying Linter now :) Co-authored-by: Frederik Wollny <[email protected]> * Added running command to Readme (#147) * Added some fancy stuff in the README * Moved logout button Moved logout button to the top right corner * Added a Messages-Window displaying sent messages per chat (#151) * displaying messages and fixed logout button * changed structure for chatlist and added better redrawing logic * fixed linting problems Co-authored-by: Rohan Sawahn <[email protected]> * fixed wrong links * removed unnecessary method Co-authored-by: Jonas Schmidt <[email protected]> Co-authored-by: Jonas Schmidt <[email protected]> Co-authored-by: Lasklu <[email protected]> Co-authored-by: sspangenberg <[email protected]> Co-authored-by: Rohan Sawahn <[email protected]> Co-authored-by: Jonas Schmidt <[email protected]> Co-authored-by: Jonas Schmidt <[email protected]> Co-authored-by: Frederik Wollny <[email protected]> Co-authored-by: Rohan Sawahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have (very strict) linting rules enforcing our code standards.
closes #101