Skip to content

🔪/✨ 5.0 #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 20, 2021
Merged

🔪/✨ 5.0 #316

merged 10 commits into from
Jan 20, 2021

Conversation

jrolfs
Copy link
Collaborator

@jrolfs jrolfs commented Jan 20, 2021

BREAKING CHANGES: removes hover-scripts build and all related dependencies and configuration files (rollup, babel, .etc).

NEW FEATURE: Strict ESLint configuration.

jrolfs added 10 commits January 19, 2021 17:25
We don't use any of the build-related tooling that this library exports. This
removes the script and all related configuration and dependencies and replaces
the build process with a simple Babel CLI based build.

BREAKING CHANGE: This removes the `hover-scripts build` script, the exported
Babel configuration, and the exported Rollup configuration. It also removes the
built-in Babel integration in the Jest configuation.
@jrolfs jrolfs self-assigned this Jan 20, 2021
@jrolfs jrolfs requested review from aarosil and nickcobbett January 20, 2021 01:41
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #316 (4beb297) into main (8ad93c8) will increase coverage by 3.30%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   89.82%   93.12%   +3.30%     
==========================================
  Files          26       25       -1     
  Lines         393      291     -102     
  Branches       87       59      -28     
==========================================
- Hits          353      271      -82     
+ Misses         33       19      -14     
+ Partials        7        1       -6     
Impacted Files Coverage Δ
src/config/eslintrc-strict.js 0.00% <0.00%> (ø)
src/config/index.js 0.00% <ø> (-100.00%) ⬇️
src/config/jest.config.js 78.57% <50.00%> (-5.64%) ⬇️
src/config/eslintrc-react.js 100.00% <100.00%> (ø)
src/config/eslintrc.js 100.00% <100.00%> (ø)
src/config/helpers/build-eslint.js 100.00% <100.00%> (ø)
src/config/commitlint.config.js 0.00% <0.00%> (-100.00%) ⬇️
src/run-script.js 94.87% <0.00%> (-2.57%) ⬇️
src/config/release.config.js 0.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad93c8...4beb297. Read the comment docs.

@jrolfs jrolfs merged commit 0192dc9 into main Jan 20, 2021
@jrolfs jrolfs deleted the beta branch January 20, 2021 01:48
@jrolfs
Copy link
Collaborator Author

jrolfs commented Jan 20, 2021

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickcobbett
Copy link

nice! did that weird bug that was blocking us awhile back get resolved. I think it had something to do with trouble extending configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants