MOB-6046: GHA gh-pages permissions #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecrets.DEVOPS_PAT, and add read permissions to the step too
F3r-n4nd0
approved these changes
Jul 24, 2024
Comment on lines
+52
to
+55
| touch $HOME/.netrc | ||
| echo "machine api.github.com" > $HOME/.netrc | ||
| echo "login ${{ secrets.GITHUB_TOKEN }}" >> $HOME/.netrc | ||
| echo "password ${{ secrets.GITHUB_TOKEN }}" >> $HOME/.netrc |
There was a problem hiding this comment.
I am unsure if we currently do, but we need to use a specific login and password for the CI system
There was a problem hiding this comment.
yeah, we have our hover-mobile-ci-user -- I am not really sure if GITHUB_TOKEN is the correct token to use, in theory GITHUB_TOKEN should work for accessing things within the same repo, so it seems like it'd be well suited for this (and we don't run the risk of the token getting invalidated unexpectedly like our DEVOPS_PAT, which caused this action to start failing to begin with). That said, if this PR doesn't work, then hover-mobile-ci-user will be the next thing I'd try.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently lost the ability to read artifacts from this repo in the GitHub action that tries to build the DocC docs to be deployed to the repo's GitHub-pages site.
This PR switches the token we're using for the
.netrcfile from the old one tosecrets.GITHUB_TOKEN, and does some miscellaneous formatting changes that my linter were complaining about.It also adds read permissions to the job.