Skip to content

Conversation

@yusukebe
Copy link
Member

@yusukebe yusukebe commented Aug 13, 2025

Fixes #4267 (comment)

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.33%. Comparing base (193d5dc) to head (58273c1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4352   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files         172      172           
  Lines       10912    10912           
  Branches     3167     3138   -29     
=======================================
  Hits         9966     9966           
  Misses        945      945           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe
Copy link
Member Author

Hi @jraoult

Nice catch. Can you review this?

Copy link
Contributor

@jraoult jraoult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this fix in my app with the case that initially failed and everything works. Thanks 🙏

@github-actions
Copy link

Bundle size check

main (193d5dc) #4352 (6978b17) +/-
Bundle Size (B) 18,320B 18,320B 0B
Bundle Size (KB) 17.89K 17.89K 0K

Compiler Diagnostics (tsc)

main (193d5dc) #4352 (6978b17) +/-
Files 270 270 0
Lines 121,198 121,198 0
Identifiers 118,561 118,561 0
Symbols 262,949 262,949 0
Types 162,734 162,734 0
Instantiations 3,037,578 3,037,578 0
Memory used 280,285K 280,386K 101K
I/O read 0.03s 0.02s -0.01s
I/O write 0s 0s 0s
Parse time 0.84s 0.82s -0.02s
Bind time 0.37s 0.34s -0.03s
Check time 4.02s 3.94s -0.08s
Emit time 0s 0s 0s
Total time 5.23s 5.1s -0.13s

Compiler Diagnostics (typescript-go)

main (193d5dc) #4352 (6978b17) +/-
Files 240 240 0
Lines 111,097 111,097 0
Identifiers 110,301 110,301 0
Symbols 355,993 355,993 0
Types 288,045 288,045 0
Instantiations 3,545,089 3,545,089 0
Memory used 225,157K 225,220K 63K
Memory allocs 9,989,525 9,989,320 -205
Parse time 0.074s 0.076s 0.002s
Bind time 0.016s 0.034s 0.018s
Check time 1.636s 1.451s -0.185s
Emit time 0s 0s 0s
Total time 1.727s 1.562s -0.165s

Reported by octocov

@github-actions
Copy link

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 38,866.17 53,086.56 34,551.16 28,960.79
hono (current) bun 38,708.88 53,440.96 33,358.63 29,327.06
Change -0.40% +0.67% -3.45% +1.26%

@yusukebe
Copy link
Member Author

@jraoult Thank you for reviewing and confirming! I'll merge this.

@yusukebe yusukebe merged commit 6b19b5e into main Aug 15, 2025
20 checks passed
@yusukebe yusukebe deleted the fix/client-remove-index-string-query-parameters branch August 15, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants