-
-
Notifications
You must be signed in to change notification settings - Fork 883
fix(client): handle query parameters in removeIndexString
#4352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): handle query parameters in removeIndexString
#4352
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4352 +/- ##
=======================================
Coverage 91.33% 91.33%
=======================================
Files 172 172
Lines 10912 10912
Branches 3167 3138 -29
=======================================
Hits 9966 9966
Misses 945 945
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @jraoult Nice catch. Can you review this? |
jraoult
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this fix in my app with the case that initially failed and everything works. Thanks 🙏
Bundle size check
Compiler Diagnostics (tsc)
Compiler Diagnostics (typescript-go)
Reported by octocov |
HTTP Performance Benchmark
|
|
@jraoult Thank you for reviewing and confirming! I'll merge this. |
Fixes #4267 (comment)
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code