Improve downloader service

[MartinHjelmare]

Breaking change

Proposed change

• Make sure to update the download directory in the config entry data, if the original download directory is relative.
• Raise ServiceValidationError if the subdirectory path is invalid.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:
• Link to developer documentation pull request:
• Link to frontend pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @erwindouna, mind taking a look at this pull request as it has been labeled with an integration (downloader) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of downloader can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign downloader Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[Copilot]

Pull Request Overview

This PR improves the downloader service by adding better validation and handling for subdirectory paths and download directories. The changes enhance error handling and ensure consistent path management.

Key changes:

• Add validation for subdirectory paths in the download service to prevent security issues
• Update config entry data when relative download directory paths are converted to absolute paths
• Add comprehensive test coverage for the new validation logic

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
homeassistant/components/downloader/__init__.py	Updates config entry data when converting relative download paths to absolute
homeassistant/components/downloader/services.py	Adds subdirectory path validation with proper error handling and translations
homeassistant/components/downloader/strings.json	Adds translation strings for new validation error messages
tests/components/downloader/conftest.py	Creates comprehensive test fixtures for downloader integration testing
tests/components/downloader/test_init.py	Adds tests for config entry setup with relative paths and error conditions
tests/components/downloader/test_services.py	Adds parametrized tests for subdirectory validation edge cases