-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
letsencrypt: Improve docs for Lets Encrypt YAML to help prevent usage + copy/paste errors #4076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
📝 WalkthroughWalkthroughDocumentation and configuration comments were updated to clarify how users should copy DNS-related YAML attributes into the UI configuration field. The updates emphasize not to include the top-level Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
letsencrypt/DOCS.md (1)
299-302
: Bold the UI string to follow repository doc styleDocs for this repo bold UI labels. Update the sentence to bold DNS Provider configuration and front the goal:
-When using the UI edit mode (which is the default), and configuring DNS, you **must** -only copy the attributes *underneath* the `dns:` key into the "DNS Provider configuration" field. +When you configure DNS in UI edit mode (default), **copy only** the attributes *underneath* the `dns:` key into the **DNS Provider configuration** field.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
letsencrypt/DOCS.md
(1 hunks)letsencrypt/config.yaml
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
*/**(html|markdown|md)
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
🔇 Additional comments (1)
letsencrypt/config.yaml (1)
35-37
: UI-specific comment reads well — LGTMThe added guidance is concise, prescriptive, and in the right place to catch copy-paste mistakes. No further adjustments needed.
Just documentation updates because we can't enforce a schema on the YAML. This should hopefully help avoid the numerous issues filed for
NoneType
errors like #3790 #3410 #3661 etc.