Skip to content

Address potentially security flaws in panel.js - #8501

Merged
philippjfr merged 3 commits into
mainfrom
resolve_js_security
Mar 12, 2026
Merged

Address potentially security flaws in panel.js#8501
philippjfr merged 3 commits into
mainfrom
resolve_js_security

Conversation

@philippjfr

@philippjfr philippjfr commented Mar 12, 2026

Copy link
Copy Markdown
Member

Description

Adds additional validation and escaping to avoid potential XSS and prototype pollution vulnerabilities.

Fixes #8449

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested all AI-generated content in my PR.
    • I take responsibility for all AI-generated content in my PR.
      Tools: ChatGPT plus manual review

Checklist

  • Tests added and is passing
  • Added documentation

@philippjfr philippjfr mentioned this pull request Mar 12, 2026
3 tasks
@RinZ27

RinZ27 commented Mar 12, 2026

Copy link
Copy Markdown

@philippjfr verified the changes locally and they look solid. Implementing the global regex and the explicit key checks for Plotly path resolution effectively mitigates those logic flaws. Great work on the quick turnaround.

@philippjfr

Copy link
Copy Markdown
Member Author

@RinZ27 appreciate the report, and thanks for testing so quickly. We'll try to get an RC for 1.8.10 out today, followed shortly by a real release (hopefully tomorrow).

@codecov

codecov Bot commented Mar 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.56%. Comparing base (7a754d4) to head (3fe2242).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8501      +/-   ##
==========================================
- Coverage   86.13%   85.56%   -0.58%     
==========================================
  Files         349      349              
  Lines       55050    55098      +48     
==========================================
- Hits        47420    47144     -276     
- Misses       7630     7954     +324     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr
philippjfr merged commit 7811ba9 into main Mar 12, 2026
14 of 19 checks passed
@philippjfr
philippjfr deleted the resolve_js_security branch March 12, 2026 12:58
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect escaping in SyntaxError display and potential Prototype Pollution in Plotly model

2 participants