Handle bleach deprecation by preferring nh3 with bleach fallback - #8480
Closed
Macdrita wants to merge 3 commits into
Closed
Handle bleach deprecation by preferring nh3 with bleach fallback#8480Macdrita wants to merge 3 commits into
Macdrita wants to merge 3 commits into
Conversation
Contributor
|
Your changes from #8479 has been pushed to this branch too. |
Member
|
Closing in favor of #8503 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6206
This PR addresses the deprecation of the
bleachlibrary used for HTML sanitization in Panel.The implementation updates the lazy sanitizer so that it attempts to use
nh3when available and falls back tobleachifnh3is not installed. This approach allows Panel to remain compatible with environments wherenh3is available while maintaining support for environments such as Pyodide wherenh3may not yet be installable.The change preserves the existing sanitizer interface and behavior while ensuring that Panel can transition away from relying solely on the deprecated
bleachpackage.How Has This Been Tested?
The change was tested locally by importing Panel after modifying the sanitizer implementation:
python3 -c "import panel"
This verifies that the module imports correctly and that the sanitizer initialization does not introduce runtime errors.
AI Disclosure
Checklist