Skip to content

Only serialize ESM model definition if session is already loaded - #8462

Merged
philippjfr merged 4 commits into
mainfrom
fix_esm_loaded
Mar 3, 2026
Merged

Only serialize ESM model definition if session is already loaded#8462
philippjfr merged 4 commits into
mainfrom
fix_esm_loaded

Conversation

@philippjfr

Copy link
Copy Markdown
Member

The fix introduced in #8432 caused a regression because it was not correctly scoped. Specifically we should only serialize model definitions if the session is already fully initialized. This change adds an additional condition using state.loaded to ensure that is the case.

@codecov

codecov Bot commented Mar 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.50%. Comparing base (8644d22) to head (abc0d38).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8462       +/-   ##
===========================================
+ Coverage   70.36%   85.50%   +15.13%     
===========================================
  Files         348      349        +1     
  Lines       55025    55026        +1     
===========================================
+ Hits        38719    47050     +8331     
+ Misses      16306     7976     -8330     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread panel/custom.py Outdated
@philippjfr
philippjfr merged commit 685cb89 into main Mar 3, 2026
17 of 20 checks passed
@philippjfr
philippjfr deleted the fix_esm_loaded branch March 3, 2026 16:09
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants