Only serialize ESM model definition if session is already loaded - #8462
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8462 +/- ##
===========================================
+ Coverage 70.36% 85.50% +15.13%
===========================================
Files 348 349 +1
Lines 55025 55026 +1
===========================================
+ Hits 38719 47050 +8331
+ Misses 16306 7976 -8330 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philippjfr
commented
Mar 3, 2026
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix introduced in #8432 caused a regression because it was not correctly scoped. Specifically we should only serialize model definitions if the session is already fully initialized. This change adds an additional condition using
state.loadedto ensure that is the case.