Skip to content

enh: Use direct html.escape import - #8409

Merged
philippjfr merged 1 commit into
mainfrom
enh_direct_import
Feb 5, 2026
Merged

enh: Use direct html.escape import#8409
philippjfr merged 1 commit into
mainfrom
enh_direct_import

Conversation

@hoxbro

@hoxbro hoxbro commented Feb 4, 2026

Copy link
Copy Markdown
Member

This confused me. When seeing this html.escape import I instantly knows this is from the stdlib.

I have left the original import for now.

@codecov

codecov Bot commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.10%. Comparing base (ec05ecd) to head (0fededd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8409   +/-   ##
=======================================
  Coverage   86.09%   86.10%           
=======================================
  Files         349      349           
  Lines       54821    54829    +8     
=======================================
+ Hits        47199    47210   +11     
+ Misses       7622     7619    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr philippjfr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was left over from a time when html.escape behaved different for different python versions.

@philippjfr
philippjfr merged commit d2843a7 into main Feb 5, 2026
38 of 40 checks passed
@philippjfr
philippjfr deleted the enh_direct_import branch February 5, 2026 10:53
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants