Skip to content

Ensure ReactComponent child is rendered when view is slow to initialize - #8406

Merged
philippjfr merged 1 commit into
mainfrom
react_child_render_fix
Feb 4, 2026
Merged

Ensure ReactComponent child is rendered when view is slow to initialize#8406
philippjfr merged 1 commit into
mainfrom
react_child_render_fix

Conversation

@philippjfr

Copy link
Copy Markdown
Member

In certain scenarios views are slow to initialize (e.g. GraphicWalker, because it has to download a large bundle). In this scenario the componentDidMount hook would run but not do anything because the view was not yet ready. By ensuring that we attach the render_callback whether or not the view can be resolved ensures that it does render when the view is ready.

We also implement some fixes ensuring no child renders are triggered when children haven't changed.

@codecov

codecov Bot commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.10%. Comparing base (30c0f60) to head (198208a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8406      +/-   ##
==========================================
+ Coverage   86.08%   86.10%   +0.01%     
==========================================
  Files         349      349              
  Lines       54821    54821              
==========================================
+ Hits        47194    47203       +9     
+ Misses       7627     7618       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr
philippjfr merged commit ec05ecd into main Feb 4, 2026
17 of 20 checks passed
@philippjfr
philippjfr deleted the react_child_render_fix branch February 4, 2026 12:16
@github-actions

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant