Skip to content

Ensure Filedropper.accepted_filetypes supports most extension types - #8380

Merged
philippjfr merged 3 commits into
mainfrom
fildropper_extension_support
Jan 21, 2026
Merged

Ensure Filedropper.accepted_filetypes supports most extension types#8380
philippjfr merged 3 commits into
mainfrom
fildropper_extension_support

Conversation

@maximlt

@maximlt maximlt commented Jan 21, 2026

Copy link
Copy Markdown
Member

Fixes #7153

Filepond's acceptedFileTypes doesn't yet support file extensions (see pqina/filepond-plugin-file-validate-type#13) while Panel documents that they are accepted. This PR adds a hard-coded mapping from extension to MIME type (partially LLM-generated) that should cover most cases.

Comment thread panel/models/file_dropper.ts Outdated
@codecov

codecov Bot commented Jan 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.10%. Comparing base (798a974) to head (6c2add5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8380      +/-   ##
==========================================
+ Coverage   86.09%   86.10%   +0.01%     
==========================================
  Files         349      349              
  Lines       54734    54734              
==========================================
+ Hits        47121    47128       +7     
+ Misses       7613     7606       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr

Copy link
Copy Markdown
Member

Thank you!

@philippjfr
philippjfr merged commit f76c780 into main Jan 21, 2026
18 of 20 checks passed
@philippjfr
philippjfr deleted the fildropper_extension_support branch January 21, 2026 15:42
@holovizbot

Copy link
Copy Markdown

This pull request has been mentioned on HoloViz Discourse. There might be relevant details there:

https://discourse.holoviz.org/t/file-drop-widget-not-working-as-expected/9057/6

@philippjfr philippjfr mentioned this pull request Jan 26, 2026
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileDropper accepted_filetypes doesn't seem to properly validate

3 participants