Ensure edit_readonly resets class and instance level parameters - #8371
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8371 +/- ##
==========================================
- Coverage 86.10% 86.10% -0.01%
==========================================
Files 349 349
Lines 54709 54747 +38
==========================================
+ Hits 47108 47138 +30
- Misses 7601 7609 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philippjfr
reviewed
Jan 14, 2026
philippjfr
reviewed
Jan 14, 2026
philippjfr
approved these changes
Jan 21, 2026
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7999
Code adapted from
edit_constant's code in Param. Example from the issue:Output before:
Output now:
We should upstream this sort of utility to Param, maybe with some API improvements (e.g. should only act on
readonlyparameters, allow to specify a subset of parameters, make it available on the .param namespace).