Skip to content

Conversation

hollodotme
Copy link
Owner

Proposed Changes

  • Add .gitattributes to exclude directories/files from archives/releases installed by composer
  • Remove link to bin/fcgiget in composer.json as it is a potential security issue (because bin/fcgiget accepts any accessible fastCGI endpoint and may be exposed in some setups.

Further comments

See #58.

mnapoli and others added 2 commits May 19, 2020 09:52
This results in a lighter package when it is installed in `vendor` in consuming projects. This makes a difference on AWS Lambda where the package size is limited, and a smaller package implies better performances for cold starts.

See https://madewithlove.com/gitattributes/ for more information.
Exclude directories from the Composer archive
@hollodotme hollodotme added this to the v3.1.2 milestone May 19, 2020
@hollodotme hollodotme self-assigned this May 19, 2020
@codecov
Copy link

codecov bot commented May 19, 2020

Codecov Report

Merging #59 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage     97.96%   97.96%           
  Complexity      253      253           
=========================================
  Files            18       18           
  Lines           639      639           
=========================================
  Hits            626      626           
  Misses           13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f67b10b...02aa35b. Read the comment docs.

@hollodotme hollodotme merged commit d97647b into master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants