Avoid expiring tab data if configuration changes #3191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hluk
force-pushed
the
fix-expire-tab
branch
3 times, most recently
from
14a47e3 to
e854ee3
Compare
Enables renaming tabs with item storing disabled. Renamed tab will have same properties as the old one.
This fixes moving "c" (tab with item) to "b" (group) in the following
tab tree:
a
└──b
└──c
└──d
The result should be:
a
└──c
└──d
The problem was that "b" group was empty while iterating the tree, which
broke the iteration process. The fix is to delete all empty groups after
the iteration.
hluk
force-pushed
the
fix-expire-tab
branch
from
e854ee3 to
600b7af
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3191 +/- ##
==========================================
+ Coverage 78.98% 79.00% +0.01%
==========================================
Files 223 224 +1
Lines 29819 29861 +42
==========================================
+ Hits 23553 23591 +38
- Misses 6266 6270 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3172
Also, enables renaming tabs with item storing disabled.
Renamed tabs will have the same properties as the old one.