fix(ruby): stricter block params, allowing bitwise OR - #4188
Open
dysonreturns wants to merge 2 commits into
Open
fix(ruby): stricter block params, allowing bitwise OR#4188dysonreturns wants to merge 2 commits into
dysonreturns wants to merge 2 commits into
Conversation
|
Thanks! I've just noticed this bug too |
joshgoebel
reviewed
Jul 5, 2026
|
|
||
| const BLOCK_PARAMS = { | ||
| className: 'params', | ||
| begin: /(do|\{)\s\|(?!=)/, |
Member
There was a problem hiding this comment.
Do we need a look-ahead for the do? How do we know it's going to have params at all? I feel like we need some new markup test cases here to make sure we get the expected behavior here.
Wouldn't this break?
setup do
# code
end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block parenthesis, which are two pipe symbols are applicable after a
do |param|or inside of an inline block{ |param| ... }.Resolves #4187
Changes
This change ensures the pipes
|param|are preceded by an open bracket{or ado.By being specific when these parenthesis occur, bitwise OR operations
|don't read what follows as params indefinitely.Checklist
CHANGES.md