Skip to content

Fix regression from 40f956b. Invalid length parameter. #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2017
Merged

Fix regression from 40f956b. Invalid length parameter. #322

merged 1 commit into from
Apr 25, 2017

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Apr 25, 2017

No description provided.

@hierynomus
Copy link
Owner

Thanks @dkocher! I think this fixes #306. Good find totally missed that

@dkocher
Copy link
Contributor Author

dkocher commented Apr 25, 2017

Would be nice if there is some test coverage that would catch this.

@hierynomus
Copy link
Owner

Agreed, do you have time to add a test? :)

@hierynomus
Copy link
Owner

I'll merge this for now and release a new release.

@hierynomus hierynomus merged commit 2b21ec6 into hierynomus:master Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkocher @hierynomus