Skip to content

Fix date serialization errors in FormData. Update bodySerializer.ts #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LZQCN
Copy link

@LZQCN LZQCN commented Jul 31, 2025

Fix date serialization errors in FormData.
The correct value is'2025-07-31T09:40:13.599Z'instead of'"2025-07-31T09:40:13.599Z"'

Fix date serialization errors in FormData
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jul 31, 2025

⚠️ No Changeset found

Latest commit: 69fd7cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jul 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2025 9:44am

@LZQCN LZQCN changed the title Update bodySerializer.ts Fix date serialization errors in FormData. Update bodySerializer.ts Jul 31, 2025
Copy link

codecov bot commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.53%. Comparing base (b9dc166) to head (69fd7cb).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2375   +/-   ##
=======================================
  Coverage   22.53%   22.53%           
=======================================
  Files         324      324           
  Lines       31840    31840           
  Branches     1232     1232           
=======================================
  Hits         7174     7174           
  Misses      24657    24657           
  Partials        9        9           
Flag Coverage Δ
unittests 22.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Add missing else
Copy link

pkg-pr-new bot commented Jul 31, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2375

commit: 69fd7cb

@mrlubos
Copy link
Member

mrlubos commented Jul 31, 2025

Hey @LZQCN you've only updated an example in this pull request, i.e. this doesn't fix anything. What you're looking for is probably https://github.com/hey-api/openapi-ts/blob/main/packages/openapi-ts/src/plugins/%40hey-api/client-core/bundle/bodySerializer.ts#L17. Could you also add a test so we can verify it fixes the issue?

@mrlubos mrlubos added the needs info ⏳ Further information is required label Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs info ⏳ Further information is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants