japanese: use pyopenjtalk instead of fugashi #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had trouble using kokoro because fugashi could not find its unidic dictionary. While looking at misaki and fugashi implementations, I discovered misaki exposed a new tokenizer https://github.com/hexgrad/misaki?tab=readme-ov-file#japanese . Using pyopenjtalk worked out of the box (as the readme mentions, the fugashi approach looks more brittle with several wrappers involved). Apparently it enables accents as well. Having never used the previous one, I cant compare the two but I've used the pyopenjtalk with sucess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble using kokoro because fugashi could not find its unidic dictionary. While looking at misaki and fugashi implementations, I discovered misaki exposed a new tokenizer https://github.com/hexgrad/misaki?tab=readme-ov-file#japanese . Using pyopenjtalk worked out of the box (as the readme mentions, the fugashi approach looks more brittle with several wrappers involved). Apparently it enables accents as well. Having never used the previous one, I cant compare the two but I've used the pyopenjtalk with sucess.