to fix truncateWords function not work properly#408
Open
VijaytParmar wants to merge 1 commit intohelpers:masterfrom
Open
to fix truncateWords function not work properly#408VijaytParmar wants to merge 1 commit intohelpers:masterfrom
VijaytParmar wants to merge 1 commit intohelpers:masterfrom
Conversation
In truncateWords function there is a one mistake, if(num > arr.length) => This will not work properly instead if(num < arr.lenght) => this will work properly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In String's truncateWords function there is a one mistake of > instead of < in if condition, That's why trucateWords not work properly
if(num > arr.length)=> This will not work properlyThis will slice array if word count is greater than total number of words, which is wrong
instead,
if(num < arr.lenght)=> this will work properlyThis will slice array if word count is less than total number of words, which is right
and now trucateWords work properly