Clarify templates directory is optional for umbrella charts#2134
Open
promptless-for-oss wants to merge 1 commit into
Open
Clarify templates directory is optional for umbrella charts#2134promptless-for-oss wants to merge 1 commit into
promptless-for-oss wants to merge 1 commit into
Conversation
Mark the templates/ directory as OPTIONAL in the chart file structure and add a note explaining that umbrella charts typically omit it. This clarifies that charts without templates pass helm lint --strict. Signed-off-by: promptless[bot] <promptless[bot]@users.noreply.github.com>
| ``` | ||
|
|
||
| Helm reserves use of the `charts/`, `crds/`, and `templates/` directories, and | ||
| of the listed file names. Other files will be left as they are. |
Contributor
Author
There was a problem hiding this comment.
Added clarification that templates/ directory is optional based on PR #32208 which restored correct linting behavior for umbrella charts. The PR changed the missing templates check from Warning to Info severity, ensuring umbrella charts pass helm lint --strict.
Source: helm/helm#32208
| Helm reserves use of the `charts/`, `crds/`, and `templates/` directories, and | ||
| of the listed file names. Other files will be left as they are. | ||
|
|
||
| The `templates/` directory is optional. Umbrella charts that only aggregate |
Contributor
Author
There was a problem hiding this comment.
Added clarification that templates/ directory is optional based on PR #32208 which restored correct linting behavior for umbrella charts. The PR changed the missing templates check from Warning to Info severity, ensuring umbrella charts pass helm lint --strict.
Source: helm/helm#32208
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open this suggestion in Promptless to view citations and reasoning process
Marks the templates/ directory as OPTIONAL in the chart file structure documentation and adds a note explaining that umbrella charts (which aggregate subcharts without having their own templates) pass helm lint --strict without issue.
Trigger Events
Tip: Tell your friends working on non-commercial open-source projects to apply for free Promptless access at promptless.ai/oss ❤️