Highlight Rust doc comments with markdown #9695
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
S-waiting-on-pr
The test changes are needed because of the changes to comment parsing. The `1..36` to `1..37` change is because line comments now consume the newline.
the-mikedavis
force-pushed
the
rust-markdown-doc-comments
branch
from
975d8b2 to
ec27d07
Compare
the-mikedavis
added
S-waiting-on-author
|
tree-sitter/tree-sitter-rust#212 was merged upstream. We might want to try to solve #6491 before merging this though: it's fairly easy to reproduce once you inject markdown into line comments and annoying when it happens if you have comments styled with italics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tree-sitter-rust recently added nodes for doc comments and we can inject in markdown. This is waiting on a few fixes/refactors in tree-sitter/tree-sitter-rust#212
Closes #3391