Skip to content

Several Code Climate fixes #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

happy5214
Copy link
Member

@happy5214 happy5214 commented Mar 11, 2025

This PR fixes three Code Climate issues.

@happy5214 happy5214 added quality Code quality, not must-fix bids BIDS integration issues BIDS and HED-specific issue data tasks labels Mar 11, 2025
@happy5214 happy5214 self-assigned this Mar 11, 2025
Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This requires adding a polyfill library dependency. This was
re-committed from the last commit to use a different version of the
dependency.
@happy5214 happy5214 force-pushed the code-climate-fixes branch 2 times, most recently from e085455 to cb8f181 Compare March 14, 2025 14:18
@happy5214 happy5214 changed the title Code Climate fixes in issues and BIDS schema loading code Several Code Climate fixes Mar 14, 2025
@happy5214 happy5214 added this to the 4.0.1 milestone Mar 14, 2025
@happy5214 happy5214 marked this pull request as ready for review March 14, 2025 21:54
@happy5214 happy5214 merged commit 7e5ffe7 into hed-standard:develop Mar 14, 2025
6 of 7 checks passed
@happy5214 happy5214 deleted the code-climate-fixes branch March 14, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bids BIDS integration issues BIDS and HED-specific issue data tasks quality Code quality, not must-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants