Skip to content

Added tests for n/a handling in onset column #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 110 additions & 0 deletions tests/testData/bidsTests.data.js
Original file line number Diff line number Diff line change
Expand Up @@ -2114,6 +2114,116 @@ export const bidsTestData = [
],
comboErrors: [],
},
{
testname: 'na-in-onset column-but-valid-hed',
explanation: 'n/a in some onset columns but valid HED',
schemaVersion: '8.3.0',
definitions: ['(Definition/Acc/#, (Acceleration/# m-per-s^2, Red))', '(Definition/MyColor, (Label/Pie))'],
sidecar: {
event_code: {
HED: {
face: 'Acceleration/5',
ball: 'Black, White',
},
},
},
eventsString:
'onset\tduration\tevent_code\tHED\nn/a\t0\tball\tRed,Blue\n5.0\t\0\tface\t((Green), Duration/4)\n',
sidecarErrors: [],
tsvErrors: [],
comboErrors: [],
},
{
testname: 'na-in-onset column-but-invalid-hed',
explanation: 'n/a in some onset columns but invalid HED',
schemaVersion: '8.3.0',
definitions: ['(Definition/Acc/#, (Acceleration/# m-per-s^2, Red))', '(Definition/MyColor, (Label/Pie))'],
sidecar: {
event_code: {
HED: {
face: 'Acceleration/5',
ball: 'Black, white',
},
},
},
eventsString:
'onset\tduration\tevent_code\tHED\nn/a\t0\tball\tRed,Baloney\n5.0\t\0\tface\t((Green), Duration/4)\n',
sidecarErrors: [],
tsvErrors: [
BidsHedIssue.fromHedIssue(
generateIssue('invalidTag', { tag: 'Baloney' }),
{
path: 'na-in-onset column-but-invalid-hed.tsv',
relativePath: 'na-in-onset column-but-invalid-hed.tsv',
},
{ tsvLine: '2' },
),
],
comboErrors: [
BidsHedIssue.fromHedIssue(
generateIssue('invalidTag', { tag: 'Baloney' }),
{
path: 'na-in-onset column-but-invalid-hed.tsv',
relativePath: 'na-in-onset column-but-invalid-hed.tsv',
},
{ tsvLine: '2' },
),
],
},
{
testname: 'all-na-in-onset column-with-duration',
explanation: 'all n/a in onset column but one has allowed Duration tag',
schemaVersion: '8.3.0',
definitions: ['(Definition/Acc/#, (Acceleration/# m-per-s^2, Red))', '(Definition/MyColor, (Label/Pie))'],
sidecar: {
event_code: {
HED: {
face: 'Acceleration/5',
ball: 'Black, white',
},
},
},
eventsString: 'onset\tduration\tevent_code\tHED\nn/a\t0\tball\tRed\n5n/a\t\0\tface\t((Green), Duration/4)\n',
sidecarErrors: [],
tsvErrors: [],
comboErrors: [],
},
{
testname: 'all-na-in-onset-column-invalid-onset',
explanation: 'all n/a in onset column with an invalid onset',
schemaVersion: '8.3.0',
definitions: ['(Definition/Acc/#, (Acceleration/# m-per-s^2, Red))', '(Definition/MyColor, (Label/Pie))'],
sidecar: {
event_code: {
HED: {
face: 'Acceleration/5',
ball: 'Black, white',
},
},
},
eventsString: 'onset\tduration\tevent_code\tHED\nn/a\t0\tball\tRed\n5n/a\t\0\tface\t(Def/MyColor, Onset)\n',
sidecarErrors: [],
tsvErrors: [
BidsHedIssue.fromHedIssue(
generateIssue('temporalTagInNonTemporalContext', { string: '(Def/MyColor, Onset)' }),
{
path: 'all-na-in-onset-column-invalid-onset.tsv',
relativePath: 'all-na-in-onset-column-invalid-onset.tsv',
},
{ tsvLine: '3' },
),
],
comboErrors: [
BidsHedIssue.fromHedIssue(
generateIssue('temporalTagInNonTemporalContext', { string: 'Acceleration/5,(Def/MyColor, Onset)' }),
{
path: 'all-na-in-onset-column-invalid-onset.tsv',
relativePath: 'all-na-in-onset-column-invalid-onset.tsv',
},
{ tsvLine: '3' },
),
],
},
],
},
{
Expand Down
Loading