Skip to content

UBERF-9550: Fix backup verification memory usage #8138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

UBERF-9550: Fix backup verification memory usage #8138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions dev/tool/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ export function devTool (
cmd.region,
5000, // 5 gigabytes per blob
sharedPipelineContextVars,
true,
true, // Do full check
async (storage, workspaceStorage) => {
if (cmd.remove) {
await updateArchiveInfo(toolCtx, db, ws.workspace, true)
Expand Down Expand Up @@ -781,12 +781,14 @@ export function devTool (
.option('--region [region]', 'Force backup of selected workspace', '')
.option('--full', 'Full recheck', false)
.option('-w|--workspace [workspace]', 'Force backup of selected workspace', '')
.action(async (cmd: { workspace: string, region: string, full: boolean }) => {
.option('-s|--skip [skip]', 'A command separated list of workspaces to skip', '')
.action(async (cmd: { workspace: string, region: string, full: boolean, skip: string }) => {
const { txes } = prepareTools()
const skipped = new Set(cmd.skip.split(',').map((it) => it.trim()))
await withAccountDatabase(async (db) => {
const workspaces = (await listWorkspacesPure(db))
.sort((a, b) => a.lastVisit - b.lastVisit)
.filter((it) => cmd.workspace === '' || cmd.workspace === it.workspace)
.filter((it) => (cmd.workspace === '' || cmd.workspace === it.workspace) && !skipped.has(it.workspace))

let processed = 0

Expand Down Expand Up @@ -819,7 +821,11 @@ export function devTool (
processed++
}
} catch (err: any) {
toolCtx.error('Failed to backup workspace', { workspace: ws.workspace })
toolCtx.error('Failed to backup workspace', {
workspace: ws.workspace,
err: err.message,
errStack: err.stack
})
}
}
console.log('Processed workspaces', processed)
Expand Down
Loading