-
Notifications
You must be signed in to change notification settings - Fork 81
Upgrade buildx
#1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade buildx
#1041
Conversation
The `docker/setup-buildx-action@v3` with `version: v0.5.1` is duplicated in 7 actions. The version used for the build system should be specified only once - extracted. Note - this version is [old](https://github.com/docker/buildx/releases/tag/v0.5.1) which is what prompted centralising to make it easier to explore upgrading in future.
This `buildx` version is [5 years old](https://github.com/docker/buildx/releases/tag/v0.5.1) - and not managed by Dependabot. We _could_ update to a newer specific version, but that's still not easily maintainable - instead we should just use `latest` and trust the post-build image smoke tests.
This reverts commit 96ccd5d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, why not dependabot? |
This isn't an action - it's the configuration of an action. Not something dependabot supports. |
In #1041, `buildx` was upgraded. [`v10` introduced a breaking change](https://github.com/docker/buildx/releases/tag/v0.10.0), the introduction of `provenance` - this caused the [RedHat publish requests to fail](https://github.com/hazelcast/hazelcast-docker/actions/runs/17074139914/job/48411435645): ``` + echo 'Publishing the image 68a4987ed81a02dbf3d1a549...' ++ curl --fail --silent --show-error --retry 5 --retry-all-errors --request POST --header 'X-API-KEY: ***' --header 'Cache-Control: no-cache' --header 'Content-Type: application/json' --data '{"image_id":"68a4987ed81a02dbf3d1a549" , "operation" : "publish" }' https://catalog.redhat.com/api/containers/v1/projects/certification/id/***/requests/images Publishing the image 68a4987ed81a02dbf3d1a549... curl: (22) The requested URL returned error: 400 ``` Disabling `provenance` addresses this issue. Example execution.
In #1041, `buildx` was upgraded. [`v10` introduced a breaking change](https://github.com/docker/buildx/releases/tag/v0.10.0), the introduction of `provenance` - this caused the [RedHat publish requests to fail](https://github.com/hazelcast/hazelcast-docker/actions/runs/17074139914/job/48411435645): ``` + echo 'Publishing the image 68a4987ed81a02dbf3d1a549...' ++ curl --fail --silent --show-error --retry 5 --retry-all-errors --request POST --header 'X-API-KEY: ***' --header 'Cache-Control: no-cache' --header 'Content-Type: application/json' --data '{"image_id":"68a4987ed81a02dbf3d1a549" , "operation" : "publish" }' https://catalog.redhat.com/api/containers/v1/projects/certification/id/***/requests/images Publishing the image 68a4987ed81a02dbf3d1a549... curl: (22) The requested URL returned error: 400 ``` Disabling `provenance` addresses this issue. The root cause of the issue with `provenance` has not been investigated further. [Example execution](https://github.com/hazelcast/hazelcast-docker/actions/runs/17083589973/job/48443063887).
This
buildx
version is 5 years old - and not managed by Dependabot.We could update to a newer specific version, but that's still not easily maintainable - instead we should just use
latest
and trust the post-build image smoke tests.Example execution.
Fixes: #1043