Fix renaming data constructors with fields (resolves #2915, resolves #4083) #4635
Conversation
|
Wait, it will require some work. It doesn't work as is, yet 😸 |
|
My bad, I saw all the tests have been passed and thought it is ready. Forget to check if the new test have been supplied😆 |
|
Looks promising, but still not 100% done. There's an issue with Record wildcards - the current impl. somehow removes the
|
jhrcek
changed the title
| @@ -24,6 +24,11 @@ tests :: TestTree | |||
| tests = testGroup "Rename" | |||
| [ goldenWithRename "Data constructor" "DataConstructor" $ \doc -> | |||
| rename doc (Position 0 15) "Op" | |||
| , goldenWithRename "Data constructor with fields" "DataConstructorWithFields" $ \doc -> | |||
| rename doc (Position 1 13) "FooRenamed" | |||
| , knownBrokenForGhcVersions [GHC96, GHC98] "renaming Constructor{..} with RecordWildcard removes .." $ | |||
There was a problem hiding this comment.
Fyi this is a separate new issue I discovered while testing this PR that affects ghc 9.6 and 9.8.
I opened a separate issue to track that: #4636
|
@jhrcek Just randomly found https://github.com/haskell/haskell-language-server/blob/master/ghcide/session-loader/Development/IDE/Session.hs#L226, do we need to increase this to invalidate existing |
Attempt at resolving #2915 and #4083