Skip to content

Document cabal diagnostic options #3971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Document cabal diagnostic options #3971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bd9afc
Document cabal diagnostic options
fendor Jan 16, 2024
5c24447
Merge branch 'master' into fix/cabal-plugin-diags
mergify[bot] Jan 17, 2024
a91138c
Merge branch 'master' into fix/cabal-plugin-diags
michaelpj Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions plugins/hls-cabal-plugin/src/Ide/Plugin/Cabal.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ descriptor recorder plId =
deleteFileOfInterest recorder ide file
restartCabalShakeSession (shakeExtras ide) vfs file "(closed)"
]
, pluginConfigDescriptor = defaultConfigDescriptor
{ configHasDiagnostics = True
}
}
where
log' = logWith recorder
Expand Down
3 changes: 2 additions & 1 deletion test/testdata/schema/ghc92/default-config.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
},
"cabal": {
"codeActionsOn": true,
"completionOn": true
"completionOn": true,
"diagnosticsOn": true
},
"callHierarchy": {
"globalOn": true
Expand Down
6 changes: 6 additions & 0 deletions test/testdata/schema/ghc92/vscode-extension-schema.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@
"scope": "resource",
"type": "boolean"
},
"haskell.plugin.cabal.diagnosticsOn": {
"default": true,
"description": "Enables cabal diagnostics",
"scope": "resource",
"type": "boolean"
},
"haskell.plugin.callHierarchy.globalOn": {
"default": true,
"description": "Enables callHierarchy plugin",
Expand Down
3 changes: 2 additions & 1 deletion test/testdata/schema/ghc94/default-config.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
},
"cabal": {
"codeActionsOn": true,
"completionOn": true
"completionOn": true,
"diagnosticsOn": true
},
"callHierarchy": {
"globalOn": true
Expand Down
6 changes: 6 additions & 0 deletions test/testdata/schema/ghc94/vscode-extension-schema.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@
"scope": "resource",
"type": "boolean"
},
"haskell.plugin.cabal.diagnosticsOn": {
"default": true,
"description": "Enables cabal diagnostics",
"scope": "resource",
"type": "boolean"
},
"haskell.plugin.callHierarchy.globalOn": {
"default": true,
"description": "Enables callHierarchy plugin",
Expand Down
3 changes: 2 additions & 1 deletion test/testdata/schema/ghc96/default-config.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
},
"cabal": {
"codeActionsOn": true,
"completionOn": true
"completionOn": true,
"diagnosticsOn": true
},
"callHierarchy": {
"globalOn": true
Expand Down
6 changes: 6 additions & 0 deletions test/testdata/schema/ghc96/vscode-extension-schema.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@
"scope": "resource",
"type": "boolean"
},
"haskell.plugin.cabal.diagnosticsOn": {
"default": true,
"description": "Enables cabal diagnostics",
"scope": "resource",
"type": "boolean"
},
"haskell.plugin.callHierarchy.globalOn": {
"default": true,
"description": "Enables callHierarchy plugin",
Expand Down
3 changes: 2 additions & 1 deletion test/testdata/schema/ghc98/default-config.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
},
"cabal": {
"codeActionsOn": true,
"completionOn": true
"completionOn": true,
"diagnosticsOn": true
},
"callHierarchy": {
"globalOn": true
Expand Down
6 changes: 6 additions & 0 deletions test/testdata/schema/ghc98/vscode-extension-schema.golden.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@
"scope": "resource",
"type": "boolean"
},
"haskell.plugin.cabal.diagnosticsOn": {
"default": true,
"description": "Enables cabal diagnostics",
"scope": "resource",
"type": "boolean"
},
"haskell.plugin.callHierarchy.globalOn": {
"default": true,
"description": "Enables callHierarchy plugin",
Expand Down