Skip to content

case sensitive language pragmas fix #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 3, 2021
Merged

case sensitive language pragmas fix #2142

merged 6 commits into from
Sep 3, 2021

Conversation

alexnaspo
Copy link
Contributor

@alexnaspo alexnaspo commented Aug 29, 2021 •
edited
Loading

Pragmas are not case sensitive - so the language pragma should auto complete with values accordingly

@jneira
Copy link
Member

jneira commented Aug 29, 2021 •
edited
Loading

Hi, many thanks (again 🙂 ) for the pr. To add a little bit of context:

jneira
jneira approved these changes Aug 29, 2021
View reviewed changes
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jneira jneira added the merge me Label to trigger pull request merge label Aug 29, 2021
@jneira jneira mentioned this pull request Aug 29, 2021
Closed
@mergify mergify bot merged commit 550fbd7 into haskell:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneira jneira jneira approved these changes

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexnaspo @jneira @alexnaspoleap