Run CI tests in docker instead of a machine. #8948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests that we ought to be running.
…other step so circleci sees correct exit code.
…t seem to be working very well for us, let's try with way more parallelism. The CircleCI UI says we've paid for 100-way parallelism, let's get a bit closer to that.
…'re splitting on that don't have tests, and so always get "No timing found". Try a different way to list packages to only get those with tests.
… the slowest packages will dominate.
…te docker can be time consuming.
…ce-remote-docker's problem. Also try skipping a couple of tests that have been associated with most of the race test failures. Let's see if that changes anything.
…ntinue not using it (in a less disruptive way.)
…re we're seeing the panics.
This reverts commit d5ad1fe.
This reverts commit c0f2586.
…ure the VAULT_CI_GO_TEST_RACE variable is visible in docker as well. Only use the xlarge executor for race tests.
…l an upstream fix arrives.
Closed
sapk
pushed a commit
to sapk-fork/vault
that referenced
this pull request
Aug 27, 2025
) (hashicorp#8948) * bump go-getter to 1.7.9 (hashicorp#8899) * bump go-getter to 1.7.9 * add changelog * go mod tidy --------- Signed-off-by: Ryan Cragun <[email protected]> Co-authored-by: Josh Black <[email protected]> Co-authored-by: Ryan Cragun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also stop skipping some tests that we ought to be running.