-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Updated Nomad Secret Engine docs with proper terminology #8938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The first step to using the vault backend is to mount it. | ||
Unlike the `generic` backend, the `nomad` backend is not mounted by default. | ||
The first step to using the secret engine is to mount it. | ||
Unlike the `cubbyhole` secret engine, the `nomad` secret engine is not mounted by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the cubbyhole secret engine is mounted by default is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep totally, and you can't disable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello!
I have vault 1.4.0 +ent and ran with
vault server -log-level=trace -dev -dev-root-token-id=root -dev-listen-address=127.0.0.1:8200 \
The two default secret engines mounted are cubbyhole and secret (kv v2). I was just trying to make the least amount of changes while updating the content. I think back in the day the default mount was named "generic".
Please advise if you would prefer something else.
What's the status with this request - the terminology does still require correction since |
@brianshumate @yhyakuna - would appreciate your input here and weather an additional PR maybe needed for CLI / commands in the docs too. |
Track this fixes with PR 16859, so closing this old PR. |
…ed changelogs as enterprise only files (hashicorp#8906) (hashicorp#8938) (hashicorp#8944) Don't categorize changelog files that begin with an underscore as enterprise only, otherwise they'll be removed when backporting changes to CE. Since we want to include links to commit SHAs in the changelog we have to create the changelog in the context of CE and thus need to backport all of those changes. We also fix a few Go tests that hand not been updated to handle the updated default inactive CE groups. Signed-off-by: Ryan Cragun <[email protected]> Co-authored-by: Ryan Cragun <[email protected]>
Previously, Vault secret engines were called "secret backends". Since then this naming convention has changed, and most docs have been updated.
In this PR I just update the page for the Nomad secret engine, which used the outdated terminology.